Set settlement modes when handling link errors (backport #15004) #15006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #14389 Without these changes, the attach frame doesn't set any settlement mode. This leads to settlement negotiation errors hiding the actual error. For example, omq amqp -y 0 -t /queues/no-such-queue omq amqp -x 0 -T /queues/no-such-queue Returned `amqp: sender settlement mode "unsettled" requested, received "mixed" from server"`, when the actual error in the next (detach) frame was `amqp:not-found`. However, the attach frame triggers a client-side error before the detach frame is processed. (cherry picked from commit f261afc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #14389
Without these changes, the attach frame doesn't set any settlement mode. This leads to settlement negotiation errors hiding the actual error.
For example,
omq amqp -y 0 -t /queues/no-such-queue
omq amqp -x 0 -T /queues/no-such-queue
Returned
amqp: sender settlement mode "unsettled" requested, received "mixed" from server", when the actual error in the next (detach) frame wasamqp:not-found. However, the attach frame triggers a client-side error before the detach frame is processed.This is an automatic backport of pull request #15004 done by Mergify.