Skip to content

Update Cowlib to 2.12.1 #7806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2023
Merged

Update Cowlib to 2.12.1 #7806

merged 2 commits into from
Apr 4, 2023

Conversation

@lhoguin
Copy link
Contributor

@lhoguin lhoguin commented Apr 3, 2023

This fixes a compilation error with OTP-26.

@essen essen force-pushed the lh-cowlib-otp26 branch from a35d970 to 4ace0ae Compare April 4, 2023 07:18
Update Cowlib to 2.12.1
31a8418 
This fixes a compilation error with OTP-26.
@essen essen force-pushed the lh-cowlib-otp26 branch from 4ace0ae to 31a8418 Compare April 4, 2023 07:19
@lhoguin lhoguin marked this pull request as ready for review April 4, 2023 07:19
@lhoguin
Copy link
Contributor Author

lhoguin commented Apr 4, 2023

Test failure was due to manual parsing of the setcookie header because there's been some (functionally non-breaking) adjustments in recent Cowlib versions. Manual parsing of headers is bad but we can worry about improving that another time.

@lhoguin lhoguin requested a review from michaelklishin April 4, 2023 12:02
@michaelklishin michaelklishin merged commit 124ccda into main Apr 4, 2023
@michaelklishin michaelklishin deleted the lh-cowlib-otp26 branch April 4, 2023 12:50
@mergify mergify bot mentioned this pull request Apr 4, 2023
Merged
mkuratczyk pushed a commit that referenced this pull request Apr 4, 2023
@mergify
Update Cowlib to 2.12.1 (backport #7806) (#7824)
d004567 
* Update Cowlib to 2.12.1

This fixes a compilation error with OTP-26.

(cherry picked from commit 31a8418)

* Fix parsing of cookie header in test suite

(cherry picked from commit 1595727)

---------

Co-authored-by: Loïc Hoguin <lhoguin@vmware.com>
mergify bot added a commit that referenced this pull request Apr 4, 2023
@mergify
Update Cowlib to 2.12.1 (backport #7806) (#7824)
29a24d2 
* Update Cowlib to 2.12.1

This fixes a compilation error with OTP-26.

(cherry picked from commit 31a8418)

* Fix parsing of cookie header in test suite

(cherry picked from commit 1595727)

---------

Co-authored-by: Loïc Hoguin <lhoguin@vmware.com>
(cherry picked from commit d004567)
michaelklishin added a commit that referenced this pull request Apr 4, 2023
@michaelklishin
Merge pull request #7826 from rabbitmq/mergify/bp/v3.11.x/pr-7824
11a4ec2 
Update Cowlib to 2.12.1 (backport #7806) (backport #7824)
This was referenced Apr 4, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelklishin michaelklishin Awaiting requested review from michaelklishin

Assignees

No one assigned

Labels

make

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lhoguin @michaelklishin