Skip to content

Conversation

@HoloRin
Copy link
Contributor

@HoloRin HoloRin commented Apr 26, 2023

Use the $(location ...) function instead of predicting the path.

This is not currently applied to the RABBITMQCTL and similar env vars because :broker-for-tests-home produces multiple files and not a single file like :rabbitmq-for-tests-run.

@mergify mergify bot added the bazel label Apr 26, 2023
@HoloRin HoloRin merged commit 93d53dc into main Apr 26, 2023
@HoloRin HoloRin deleted the rin/simplify-rabbitmq-run-reference-bazel branch April 26, 2023 07:29
HoloRin added a commit that referenced this pull request Apr 26, 2023
Simplify the reference to RABBITMQ_RUN in bazel in integration tests (backport #7989)
HoloRin added a commit that referenced this pull request Apr 26, 2023
…(backport #7989) (backport #7992) (#7995)

* Simplify the reference to RABBITMQ_RUN in bazel in integration tests

(cherry picked from commit 3e83c97)
(cherry picked from commit 330aa8a)

# Conflicts:
#	rabbitmq.bzl

* Fixup backport

---------

Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
mergify bot added a commit that referenced this pull request Apr 26, 2023
…(backport #7989) (backport #7992) (#7995)

* Simplify the reference to RABBITMQ_RUN in bazel in integration tests

(cherry picked from commit 3e83c97)
(cherry picked from commit 330aa8a)

# Conflicts:
#	rabbitmq.bzl

* Fixup backport

---------

Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
(cherry picked from commit 505c7ae)

# Conflicts:
#	rabbitmq.bzl
HoloRin added a commit that referenced this pull request Apr 26, 2023
…(backport #7989) (backport #7992) (backport #7995) (#7998)

* Simplify the reference to RABBITMQ_RUN in bazel in integration tests (backport #7989) (backport #7992) (#7995)

* Simplify the reference to RABBITMQ_RUN in bazel in integration tests

(cherry picked from commit 3e83c97)
(cherry picked from commit 330aa8a)

# Conflicts:
#	rabbitmq.bzl

* Fixup backport

---------

Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
(cherry picked from commit 505c7ae)

# Conflicts:
#	rabbitmq.bzl

* Fixup backport

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants