feat(neutron): Prevent SVI routers from using external gateways PUC-1754#2134
Merged
Conversation
nidzrai
force-pushed
the
svi_external_gateway
branch
from
b0d19f5 to
2018018
Compare
nidzrai
force-pushed
the
svi_external_gateway
branch
from
7d09bd1 to
12c343a
Compare
cardoe
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://rackspace.atlassian.net/browse/PUC-1754
A single subscriber on the Svi class, resources.ROUTER_GATEWAY, [events.BEFORE_CREATE] , It fires before the gateway port is created, so nothing is written or rolled back. Neutron's callback-failure handler re-raises the underlying exception directly (raise e.errors[0].error), giving a Badrequest.
iAd-dev testing :
scenerio 1: create SVI flavoured router add external gateway
scenerio 2 : Assign ext gateway while creating svi router
[Multihoming lets one router have multiple external gateway ports at the same time, instead of only one classic external_gateway_info gateway.]
Scenerio 4: Multihoming : The router ended up with multiple entries in external_gateways
scenerio 4 : non-svi router are not impacted
Known limitation [WIP]
A legacy SVI router that already had a gateway before this change could still receive additional gateways via the multihoming extra-gateway path (which skips ROUTER_GATEWAY BEFORE_CREATE). Not reachable in normal forward operation, since new SVI routers can never acquire a first gateway.