Conversation
mflatt
reviewed
Aug 17, 2018
| @defform[(stream* expr ...)]{ | ||
| A shorthand for nested @racket[stream-cons]es, but the final @racket[expr] | ||
| @defform[(stream* expr ... rest-expr)]{ | ||
| A shorthand for nested @racket[stream-cons]es, but the final argument |
Member
There was a problem hiding this comment.
Please use "argument" only for function arguments, not for subexpressions in a form.
mflatt
reviewed
Aug 17, 2018
racket/collects/racket/stream.rkt
Outdated
| (let ([tl-val tl]) | ||
| (if (stream? tl-val) | ||
| tl-val | ||
| (raise-argument-error 'stream* "stream?" tl-val)))] |
Member
There was a problem hiding this comment.
Probably the expansion in this case should call a function to check the argument and potentially raise an error, instead of inlining the checking and error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.