Skip to content

Repair types for quotient/remainder. #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Repair types for quotient/remainder. #1052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions typed-racket-lib/typed-racket/base-env/base-env-numeric.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,7 @@
(-Real . -> . -NonNegReal)))


(define (quotient-reminder-cases . cases)
(define (quotient-remainder-cases . cases)
(for/lists (qs rs qrs)
([i (in-list cases)])
(match-define (list a b (list c d)) i)
Expand All @@ -692,7 +692,7 @@
(-> a b (-values (list c d))))))

(define-values (quotient-spec remainder-spec quotient/remainder-spec)
(quotient-reminder-cases
(quotient-remainder-cases
(list -Zero -Int (list -Zero -Zero))
(list -One -One (list -One -Zero))
;; division by one is identity, and has no remainder
Expand All @@ -707,6 +707,7 @@
(list -Fixnum -One (list -Fixnum -Zero))
(list -Byte -Nat (list -Byte -Byte))
(list -Byte -Int (list -Fixnum -Byte))
(list -Index -Byte (list -Index -Byte))
(list -Index -Nat (list -Index -Index))
(list -Index -Int (list -Fixnum -Index))
(list -NonNegFixnum -Byte (list -NonNegFixnum -Byte))
Expand Down