type for the optional arguments of 'in-fx/fl/extflvector'

[bdeket]

add type for the optional arguments of 'in-fx/fl/extflvector' as in 'in-vector'

[bdeket]

What would be a good test for this? Or how how to test this?

I see

[tc-e (for/list : (Listof Flonum) ([a (in-flvector (flvector 1.0 2.0))]) a)
             (-lst -Flonum)]

in the unit-test/typecheck-tests.rkt file. Best to add an extra test over there?

[sorawee]

Since you are already adding a new test file, putting it there also makes sense. But really, I don't care where it's tested (though other people might, idk).

[samth]

This test should be behind a (when (extflonum-available?) ...) check.

[bdeket]

I see this fails for the cs branch, and looking into it, I don't understand why it succeeds on the bc branch.
the for expands to normalise-inputs, where the start/stop/step-indexes can be Nat/( U #f Nat)/Nat.

I don't know if typed-racket does something extra but if it is just using the racket implementation then I think the types for the indexes should be:
Nat/(U #f Nat -1)/(U Positive-Integer Negative-Integer)

I can change the test, to only count upwards in a for loop,
or look into changing the type for normalise-inputs...
And maybe also change the type for the step from Integer to (U Positive-Integer Negative-Integer) for in-vector and friends

[bdeket]

@samth, I went ahead and changed the type for normalise-inputs to allow going backward through the vector.

[samth]

Fantastic! I'll take a look and hopefully we can merge soon.

[samth]

Can you say more about this failure?

[bdeket]

I was hoping to be able to do:
(for/list : (Listof Fixnum) ([i (in-fxvector (fxvector 1 2 3 4) 3 -1 -2)]) i)
but without the annotation of (Sequenceof Fixnum) and Fixnum for i (both are necessary) The resulting list is seen as (Listof Integer)

[capfredf]

I took a quick look at this failure. Seems it has something to do with unsafe-normalise-inputs and normalise-inputs. I might get back to some point later next week

[samth]

I'm going to merge this now; we can try to make that example work with less annotation in the future.