This repository was archived by the owner on Aug 1, 2023. It is now read-only.
Updating download function to use reader#272
Merged
smashwilson merged 1 commit intorackspace:masterfrom Oct 27, 2014
jamiehannaford:streaming-downloads
Merged
Updating download function to use reader#272smashwilson merged 1 commit intorackspace:masterfrom jamiehannaford:streaming-downloads
smashwilson merged 1 commit intorackspace:masterfrom
jamiehannaford:streaming-downloads
Conversation
Contributor
There was a problem hiding this comment.
👍 Nice. I was thinking we should keep a method around to do this.
Contributor
There was a problem hiding this comment.
I believe this needs to call dr.Body.Close()?
Contributor
Author
There was a problem hiding this comment.
@pquerna yes, I think you're right - you can't really do anything with res.Body after it's been read to EOF
Contributor
|
|
smashwilson
added a commit
that referenced
this pull request
Oct 27, 2014
Updating download function to use reader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As #271 highlights, we're casting everything into a slice of bytes at the moment - so we should probably switch to a reader. This PR is just my initial thoughts, so feel free to suggest a better approach if anything pops into your head 😄