This repository was archived by the owner on Aug 1, 2023. It is now read-only.
DeleteResult consistency#274
Merged
smashwilson merged 20 commits intorackspace:masterfrom Oct 27, 2014
jamiehannaford:result-consistency
Merged
DeleteResult consistency#274smashwilson merged 20 commits intorackspace:masterfrom jamiehannaford:result-consistency
smashwilson merged 20 commits intorackspace:masterfrom
jamiehannaford:result-consistency
Conversation
added 10 commits
October 27, 2014 11:25
jamiehannaford
changed the title
Contributor
There was a problem hiding this comment.
What do you think about giving DeleteResult an Extract method that returns only the error, like ActionResult does? If not, should we take away ActionResult's method?
added 7 commits
October 27, 2014 14:01
Contributor
There was a problem hiding this comment.
☝️ This should be changed to gophercloud.ExtractErrResult, yes?
Contributor
Author
|
I think this is ready for review again 🚀 |
Contributor
|
👍 Nice. Thanks 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #260