Quality Pass: UI Views & Components

[dhilgaertner]

Parent: #53

Scope

All SwiftUI views and UI components: session sidebar, session detail, ticket board (Kanban), allow list view, settings tabs, setup wizard, about window, and CorveilTheme design tokens.

• Refactoring — identify and address code quality improvements
• Documentation — ensure adequate inline and user-facing docs
• Code Review — thorough review for correctness, edge cases, security
• Testing — add/improve tests for key functionality

Key Files

• Packages/CrowUI/Sources/CrowUI/MainContentView.swift — NavigationSplitView container
• Packages/CrowUI/Sources/CrowUI/SessionListView.swift — sidebar with grouped sessions, search (461 lines)
• Packages/CrowUI/Sources/CrowUI/SessionDetailView.swift — three-row header, terminal area (434 lines)
• Packages/CrowUI/Sources/CrowUI/TicketBoardView.swift — issue tracking with pipeline/list views (566 lines)
• Packages/CrowUI/Sources/CrowUI/AllowListView.swift — permission aggregation and promotion (181 lines)
• Packages/CrowUI/Sources/CrowUI/SettingsView.swift — General/Workspaces/Notifications tabs (238 lines)
• Packages/CrowUI/Sources/CrowUI/SetupWizardView.swift — first-launch wizard (262 lines)
• Packages/CrowUI/Sources/CrowUI/CorveilTheme.swift — design tokens (gold #DDC482, dark backgrounds)

Areas of Interest

• Component reusability (SessionRow, StatusBadge, PRBadge, LinkChip, DetailLabel, SectionDivider)
• Sidebar sections (Manager/Allow List pinned, Active, In Review, Completed)
• Ticket board pipeline view (Backlog → Ready → In Progress → In Review → Done)
• Search/sort/filter across views
• Keyboard shortcuts (Cmd+, for settings)
• Accessibility and dark mode support
• State observation patterns (@observable, callback closures)