Quality pass: UI views & components#91
Merged
dhilgaertner merged 3 commits intomainfrom Apr 6, 2026
Merged
Conversation
Refactor CrowUI package to eliminate code duplication, add accessibility support, improve consistency, and establish test coverage. - Extract shared components: BrandmarkImage, SearchField, CapsuleBadge, shortenBranch(), TicketStatus.color, SessionStatus.displayName, PRStatus check/review icon/color/label extensions, CorveilTheme.bgDone - Fix StatusBadge rendering "Inreview" instead of "In Review" - Fix PRStatusDetail brace nesting bug - Add accessibility labels to all icon-only buttons and status indicators - Add doc comments to all key internal components - Log delete-session errors instead of silently swallowing with try? - Add duplicate workspace name validation in settings and setup wizard - Add 17 unit tests covering shared logic and message builders Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Consolidate test and build jobs into a single build-and-test job that dynamically discovers and runs tests for all packages with a Tests/ directory. This ensures CrowUI tests (and any future package tests) run in CI with full dependencies available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Update the test job to discover and run tests for all packages with a Tests/ directory, instead of only CrowCore. The test job now includes Ghostty framework setup (needed by CrowUI's dependency on CrowTerminal). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dhilgaertner
force-pushed
the
feature/crow-73-quality-pass-ui
branch
from
db11f90 to
f3fd340
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #73
Test plan
make buildcompiles without errorsswift testinPackages/CrowUI— 17 tests passswift testinPackages/CrowCore— 3 existing tests still pass🤖 Generated with Claude Code