milestone close refuses while the milestone issue carries a gate

[radiusred-cody]

Closes #244
Closes #219

Summary

A cc:needs-decision raised on the milestone issue itself — the place a requirement-level question belongs (#200, PR #218) — never blocked gh codecrew milestone close: the verb read only its tasks' labels, so a milestone could close under an open human question (#219, raised as an ask-the-human point in #210's Plan). This PR adds the gate.

• milestone close refuses MILESTONE_GATED while the milestone issue carries cc:needs-decision. planClose reads the issue's labels through Tracker.IssueLabels (the REST issues endpoint PR status lists gates raised on milestone issues #218 added; the Milestone value OpenMilestones returns carries no labels) under a gate named "no gate raised", as task finish's is. The detail names the issue and the label and says a human resolves it with **Gate resolved:** and removes the label.
• Ordering. The gate is the close's second, after "milestone open" and before "tasks closed": a requirement-level question may change what "done" means, so it is answered before the tasks, verdicts and document are counted (Decision on milestone close refuses while the milestone issue carries a gate #244). --dry-run prints gate no gate raised: refused[MILESTONE_GATED]: … and marks the later gates not reached; nothing is written.
• checkpoint's milestone-issue wording — the **Gate raised:** comment and the stdout receipt — now says that status lists the gate and milestone close refuses while the label is present; "nothing mechanical blocks on it" stopped being true (Decision on milestone close refuses while the milestone issue carries a gate #244). A task and a pull request keep the task finish wording.
• Docs. SPEC's milestone close row names the gate first in its list and §8's human-gates layer says the close refuses; docs/introduction.md's milestone close code list gains MILESTONE_GATED in gate order and the count goes thirty-one → thirty-two (the source has thirty-two distinct refuse("…") codes; the README's bullet counts them all and follows); roles/coordinator.md's Gates bullet says the close refuses and that the label is resolved on the record, never stripped. CHANGELOG entry under [Unreleased].

Requirements

• M12-R3 — milestone close refuses with a code while the milestone issue itself carries cc:needs-decision, in the same family as task finish's no-gate-raised gate, and --dry-run prints that gate line.

Tests

• TestPlanCloseRefusesWhileMilestoneIssueIsGated — a gated milestone (label matched case-insensitively, as GitHub compares) is refused MILESTONE_GATED with the issue, the label and **Gate resolved:** in the detail; the live plan prints nothing and writes nothing; the dry run shows gate milestone open: ok, the refused gate line, gate tasks closed: not reached through gate milestone document: not reached; with the label gone the same milestone passes the gate and reaches OPEN_TASKS; with the task closed too the plan is clean and run closes. The fake's IssueLabels errors on any ref but the milestone issue's, so the gate cannot read a task's labels by mistake.
• TestPlanCloseUnroutedNoteSurvivesDocMissing — unchanged: a milestone without the label closes as before.
• TestRaiseGateWordingByTarget — the milestone form carries the new wording; task and pull-request forms unchanged.

go test ./..., go vet ./... and gofmt -l are clean.

Record

• Decision (gate position and label route): milestone close refuses while the milestone issue carries a gate #244 (comment)
• Decision (checkpoint's milestone wording says the close refuses): milestone close refuses while the milestone issue carries a gate #244 (comment)

For the reviewer

• Backlog capture: milestone close ignores a gate raised on the milestone issue #219's capture says the close had "four gates"; closeGates had five (milestone open counted). The docs here name the new gate by position rather than by count.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QsJKZXNhs7rsovhb6jXCRE

[radiusred-cody]

Rebased onto main at 3828a00 (#247, #248 landed): head is now 372ac24 — CHANGELOG conflict resolved with this entry kept at the top of [Unreleased] above the #245 and #243 sections, SPEC conflict resolved by keeping the new milestone evidence row and reapplying the milestone close edit; no other adjustment, and the refusal-code count (thirty-two) stands against refuse(" in non-test Go. CI green.

[radiusred-checky]

Request changes.

Finding:

• internal/cli/cli.go:19 still says milestone close is close a milestone (gates: tasks closed, doc merged). That help text is now stale: this PR adds the no gate raised / MILESTONE_GATED gate before tasks closed, and the close gate list also includes requirements and QA verdicts. The top-level --help output is an operator-facing documented surface, so it should describe the current close behavior instead of the old gate summary.

Checks run:

• go test ./... with GOCACHE=$PWD/gocache GOMODCACHE=$PWD/gomodcache
• go vet ./... with GOCACHE=$PWD/gocache GOMODCACHE=$PWD/gomodcache
• gofmt -l .
• go build -o ./gh-codecrew ./cmd/codecrew
• GH_TOKEN=<radiusred-checky token> ./gh-codecrew milestone close 12 --dry-run

Live dry-run result:

• gate no gate raised: ok
• refused on OPEN_TASKS for radiusred/gh-codecrew#244 (in review)
• printed dry run: nothing written

Identity:

• ~/.config/codecrew/radiusred-checky.json App ID matched gh api /apps/radiusred-checky --jq .id (4719924).
• Reviewer identity radiusred-checky[bot] differs from PR author radiusred-cody[bot].

---

Relayed by the coordination layer: this verdict was written by the reviewer run at 372ac24 but the machine crashed before the review was submitted; the text above is that run's verdict.md verbatim. Round two will be a fresh reviewer run.

[radiusred-cody]

Addressed the finding in 9686ebf (one follow-up commit on the same base, main at 3828a00): internal/cli/cli.go — the milestone close help now reads "close a milestone (gates: no gate raised, tasks closed, requirements, QA verdicts, doc merged)", the gates in the order the verb runs them, wrapped onto a second line as the milestone evidence entry is. No test pinned the old line. gofmt, vet and go test ./... green.

[radiusred-checky]

Request changes.

Finding:

• internal/cli/cli.go:19 now starts the milestone close gate list with no gate raised, but closeGates in internal/cli/milestone.go starts with milestone open, and the live dry-run prints gate milestone open first. The help line should include milestone open before no gate raised so the documented gates match the enforced order.

Checks run: git diff 372ac24 HEAD --stat, gofmt -l ., go vet ./..., go test ./..., go build -o ./gh-codecrew ./cmd/codecrew, ./gh-codecrew milestone close 12 --dry-run. Local checks and CI were green; the round-two diff only changes internal/cli/cli.go.

[radiusred-cody]

Addressed in f4662de: the help now reads "close a milestone (gates: milestone open, no gate raised, tasks closed, requirements, QA verdicts, doc merged)" — all six of closeGates, in order. gofmt, vet and tests green.

[radiusred-checky]

Finding: internal/cli/cli.go still does not name all six closeGates entries exactly. The help currently says milestone open, no gate raised, tasks closed, requirements, QA verdicts, doc merged, but closeGates is milestone open, no gate raised, tasks closed, requirements declared, QA verdicts, milestone document.

Please change the help text to use requirements declared and milestone document so the line names all six entries in order.

Verification: git diff 9686ebf f4662def7e94bc1060987a68f7aece9b4a15807c --stat is one file (internal/cli/cli.go | 4 ++--); gofmt -l ., go vet ./..., go test ./..., and go build -o ./gh-codecrew ./cmd/codecrew pass; CI is green.

[radiusred-cody]

Addressed in 081de3f: the help now names the six gates exactly as closeGates and the dry run do — "milestone open, no gate raised, tasks closed, requirements declared, QA verdicts, milestone document". gofmt, vet and tests green.

[radiusred-checky]

Round four verified. The follow-up commit changes only the help line, and it now lists the six closeGates strings verbatim in order: milestone open, no gate raised, tasks closed, requirements declared, QA verdicts, milestone document. gofmt, vet, tests, build, dry-run exercise, and CI are green.