fix: omit hook_attributes from webhook-less identity manifests - #75
Merged
radiusred-cody[bot] merged 1 commit intoAug 24, 2026
Merged
Conversation
davison
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74.
Remediates the first live-fire finding on #73: GitHub requires
hook_attributes.urlwheneverhook_attributesis supplied, regardless ofactive, so v0.3.0's webhook-off default ("hook_attributes": {"active": false}) failed manifest validation with the misleading"url" wasn't supplied— the error names the sub-object's url, not the homepage, which was present.The fix keeps the design intent exactly: a webhook-less manifest now carries no
hook_attributesat all, which registers the App with no webhook — the acts-never-listens default.--with-webhookbuilds the object active with its url and the protocol-traffic events, unchanged.Tests updated in the same commit (#46): the webhook-off test now asserts the key is absent; the
--with-webhookand refusal tests are unchanged and still pass.No release rides this: per the Decision on #73, discovery iterations run on source builds — v0.3.1 waits for the proof run.