fix(coil): stop shipping upstream's update feed, which we never actually disabled

[radroid]

The check restored in #97 failed on its first real run, on both platforms — and it was right to.

What it found

app-update.yml is in the bundle:

.../T3 Coil (Alpha).app/Contents/Resources/app-update.yml
.../win-unpacked/resources/app-update.yml

It is in the installed build too. 0.0.33-coil.105 on disk right now contains:

owner: radroid
repo: t3code
provider: github
releaseType: release
updaterCacheDirName: t3code-updater

So has every build before it. This is not a regression #97 introduced — it is what the old check could not see, because it searched release/ for a file that only ever exists inside the .app.

Why it was never disabled

The workflow set GITHUB_REPOSITORY: "", and its comment claimed that made resolveGitHubPublishConfig return undefined and no feed get written.

Actions refuses to let a workflow set any GITHUB_-prefixed variable, so that line is inert. The build read the runner's real radroid/t3code, resolved a publish config, and electron-builder wrote the feed.

The shipped file is the proof of which branch ran — owner: radroid, repo: t3code cannot be produced by any other path through that function.

The fix

T3CODE_DESKTOP_UPDATE_REPOSITORY is the fork's own hook, is consulted first, and is not reserved:

const rawRepo = (updateRepository?.trim() || githubRepository?.trim() || "").trim();
if (!rawRepo) return undefined;
const [owner, repo, ...rest] = rawRepo.split("/");
if (!owner || !repo || rest.length > 0) return undefined;   // <- "disabled" lands here

Set to disabled it short-circuits GITHUB_REPOSITORY before that is read, fails the owner/repo split, and returns undefined — the no-publish path. No publish config, no app-update.yml, hasUpdateFeedConfig false, upstream's electron-updater switches itself off. Which is what the empty string was always meant to achieve.

Depending on a parse failure would be fragile alone. It is not alone: the restored check asserts the outcome on every release, so if that parser ever loosens, the release goes red instead of shipping.

Why this was urgent rather than merely wrong

releaseType: release kept the second updater inert by accident: every fork release was a GitHub prerelease, so electron-updater could never find anything to install.

#96 has just made releases full releases with a real Latest pointer. The next successful publish would have been the first thing that dormant updater could see — in every installed build, alongside the fork's own toast. That is issue #47's failure mode, arriving on its own.

Tests

Pin both directions: that the hook produces no config, and that GITHUB_REPOSITORY alone still produces one — so a later reader cannot conclude the hook is redundant and remove it. They live in the fork's test file; resolveGitHubPublishConfig is exported, so this costs no seam row.

Lint, typecheck and the suite are clean locally.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 095399ea-794f-4a46-8754-5e6acdda5747

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}