Expand xAI reasoning effort to medium and xhigh - #35
Merged
Conversation
- Widen `XAI_EFFORTS` from `low|high` to `low|medium|high|xhigh`. - Default the xAI effort slider to `high` when none is set. - Cover the new catalog in config and picker tests.
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
No motivation was provided.
What's New
xAI Effort Catalog
XAI_EFFORTSnow acceptslow,medium,high, andxhighin config and the effort picker.highwhen no effort is stored.xhighas valid andnoneas rejected for xAI.Changed Files
src/domain/config/config.tsXAI_EFFORTSsrc/infra/ui/effort-picker.tshightest/domain/config/config.test.tsxhigh; rejectnonetest/infra/ui/effort-picker.test.tsselectXaiEffortoptionsTesting & Feedback
Confirm
commit efforton an xAI model listsmediumandxhigh, and that a savedxhighconfig still loads.If you find any bugs or have recommendations for improvements, please open an issue and assign it to me.
Note
Cursor Bugbot is generating a summary for commit 87579fa. Configure here.