You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Worker 401 path escapes the version header (from PR docs(#4): raise X-Http-Sql-Version emission from SHOULD to MUST #16): now that X-Http-Sql-Version is MUST, the D1 worker's auth-failure response path (Hono app.onError / early 401) must be verified to carry the header; the reviewer flagged it as unverified.
D1 last_row_id over-reporting (from PR fix(#6): narrow lastInsertId to string or null #17): D1 returns meta.last_row_id = 0 on SELECT/UPDATE/DELETE, now emitted as "0" -- a misleading lastInsertId for statements that inserted nothing. Map 0-on-non-INSERT to null, or verify D1's actual semantics and document.
Resolved en route, recorded so nobody re-files: PR #19's exclusion of lastInsertId from the tagged-value MUSTs was justified by its then string|number union; #17's narrowing to string-or-null makes the exclusion permanently coherent (a decimal string loses nothing). No action.
Done When
Each numbered item fixed or explicitly dispositioned on this card
Goal
One card for the small items the v0.2 wave's workers and reviewers explicitly deferred, so none silently evaporates.
Each is independent, small, and was consciously left out of its parent PR with a reason. Work them as one housekeeping pass or peel off individually.
The items
X-Http-Sql-Versionis MUST, the D1 worker's auth-failure response path (Honoapp.onError/ early 401) must be verified to carry the header; the reviewer flagged it as unverified.last_row_idover-reporting (from PR fix(#6): narrow lastInsertId to string or null #17): D1 returnsmeta.last_row_id = 0on SELECT/UPDATE/DELETE, now emitted as"0"-- a misleading lastInsertId for statements that inserted nothing. Map 0-on-non-INSERT to null, or verify D1's actual semantics and document.Resolved en route, recorded so nobody re-files: PR #19's exclusion of
lastInsertIdfrom the tagged-value MUSTs was justified by its then string|number union; #17's narrowing to string-or-null makes the exclusion permanently coherent (a decimal string loses nothing). No action.Done When
Context