Ensure connection is closed for single-value SSE streams#264
Merged
rsamoilov merged 1 commit intorage-rb:mainfrom Apr 7, 2026
Merged
Ensure connection is closed for single-value SSE streams#264rsamoilov merged 1 commit intorage-rb:mainfrom
rsamoilov merged 1 commit intorage-rb:mainfrom
Conversation
3a53e13 to
1b486de
Compare
1b486de to
60388fc
Compare
rsamoilov
approved these changes
Apr 7, 2026
Member
rsamoilov
left a comment
There was a problem hiding this comment.
Looks good. Thank you 🚀
I'm extremely happy you're looking into the SSE functionality given your experience!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
ensure connection.closetoSSE::Application#send_dataso the Iodine connection is always closed for single-value SSE streams, even whenRage::SSE.__serializeorconnection.writeraises.Problem
start_formatted_stream(Enumerator path) hasensure connection.close.start_raw_stream(Proc path) has arescueblock (#248). Butsend_data(single-value path) has no error handling — if__serializeraises (e.g.to_jsonon an object with circular references, encoding errors, or a brokento_jsonimplementation),connection.closenever executes and the connection leaks until Iodine's socket timeout.Why
ensure(notrescue)?Single-value streams are synchronous and one-shot — the connection should always close after
send_data, regardless of success or failure. This matches theensure connection.closepattern already used bystart_formatted_stream.Test plan
Added 3 test cases for
#send_data(single-value streams had no dedicated tests):