Add tests for SSE log context propagation across fiber boundaries#267
Merged
rsamoilov merged 1 commit intorage-rb:mainfrom Apr 9, 2026
Merged
Conversation
360b225 to
5b473ae
Compare
5b473ae to
ce1d824
Compare
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add tests for the log context capture/restore cycle in
SSE::Application, where parent fiber log tags are saved during initialization and restored in the child fiber spawned bystart_stream.Context
While working on the SSE specs for #248 and #264, I noticed that every aspect of
SSE::Applicationnow has dedicated test coverage: graceful shutdown (#261), connection cleanup for raw streams (#248), single-value streams (#264). But the context propagation itself had none.The capture happens at initialization:
The restore happens in the streaming fiber:
This is the mechanism that ensures log correlation survives the fiber boundary. Without it, a streaming response loses its request ID and any custom log context.
Test plan
4 tests covering:
Capture from parent fiber on initialization
Restore in child fiber for enumerator streams
Restore in child fiber for proc streams
Nil context handled gracefully
bundle exec rspec spec/sse/ -- 57 examples, 0 failures