Skip to content

Address CodeRabbit nitpicks from #97 - #99

Merged
Suede0619 merged 1 commit into
mainfrom
suede13
Jul 21, 2026
Merged

Address CodeRabbit nitpicks from #97#99
Suede0619 merged 1 commit into
mainfrom
suede13

Conversation

@Suede0619

@Suede0619 Suede0619 commented Jul 21, 2026

Copy link
Copy Markdown
Member

Two low-severity fixups CodeRabbit flagged on #97 (the SEO/AEO PR), left open at the time.

What changed

  • join/page.tsxopenGraph.url was an absolute URL; now relative (/join), resolved via metadataBase for consistency with alternates.canonical.
  • sitemap.ts — dropped lastModified: new Date(). It reported build/request time on every request for two mostly-static routes; crawlers may start ignoring the field if it changes with no real content update.

Verified

bun run build clean. Dev server confirms og:url resolves to https://www.raidguild.org/join and the sitemap no longer emits <lastmod>.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the canonical URL configuration for the Join page.
    • Simplified sitemap metadata by removing inaccurate or unnecessary last-modified timestamps.

- join/page.tsx: openGraph.url now relative ("/join"), resolved via
  metadataBase for consistency with alternates.canonical.
- sitemap.ts: drop lastModified. new Date() reported build/request
  time on every request for mostly-static routes, which crawlers may
  learn to ignore if it changes with no real content update.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: website.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fb4f1994-e436-4b73-8b8b-318869a52c13

📥 Commits

Reviewing files that changed from the base of the PR and between 9564e0c and 91b3391.

📒 Files selected for processing (2)
  • src/app/join/page.tsx
  • src/app/sitemap.ts

📝 Walkthrough

Walkthrough

The join page now uses a relative canonical path, and sitemap entries no longer include lastModified timestamps.

Changes

SEO metadata updates

Layer / File(s) Summary
Join canonical path
src/app/join/page.tsx
Changes the canonical metadata value from the absolute URL to /join.
Sitemap entry fields
src/app/sitemap.ts
Removes the shared timestamp and lastModified fields from sitemap entries.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • raid-guild/website#97: Added the canonical metadata and sitemap lastModified fields changed by this PR.

Suggested reviewers: skuhlmann

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch suede13

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Suede0619
Suede0619 merged commit b630790 into main Jul 21, 2026
0 of 2 checks passed
@Suede0619
Suede0619 deleted the suede13 branch July 21, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant