Feature/dapp run e2e tests in ci workflow#2197
Merged
weilbith merged 4 commits intoOct 5, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2197 +/- ##
=======================================
Coverage 94.76% 94.76%
=======================================
Files 156 156
Lines 6132 6132
Branches 1146 1146
=======================================
Hits 5811 5811
Misses 259 259
Partials 62 62
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Contributor
Author
|
Also this might look fatal, Talel and I don't see why the tests are dropping. |
Contributor
Author
|
It worked... 🤷 |
The vue-cli plugin for Cypress is kinda hiding it. This will lead to issues in the continuous integration environment. Therefore the cypress package itself got added to the development dependencies of the dApp. Important to note is that they need to match exactly the version expected by the vue-cli plugin. This version is pretty ancient already, but there is an open issue upstream to fix that. We will should update as soon as this has been fixed. Additionally the CI will need access to the cached Cypress binary. On this old version of the package it is required to call the install command manually. To ensure the installation this got added to the test:e2e script. If it is already installed this does nothing.
The end-to-end tests for the dApp should run in the continuous integration environment. Therefore a first version of a new job has got created. This runs the tests with Cypress and stores the report, screenshots and videos. This job is so far running within the base executor, chained after the dApp built. Also the job got integrated into the default workflow to test it while under development. Both will change in future when using the integration executor and running nightly.
weilbith
force-pushed
the
feature/dapp-run-e2e-tests-in-ci-workflow
branch
from
013f5fa to
7190cd8
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successor of #2190
Related to # 1584
Short description
Note that this is running the tests within the base executor atm. Following PRs will integrate this into the full environment image.
Checkout this comment for a link that proves that the CI upload of test report summary and artifacts (screenshots/videos) for failing tests is working.