Revisit gevent exception handling#2171
Merged
jomuel merged 1 commit intoraiden-network:masterfrom Aug 17, 2018
Merged
Conversation
jomuel
force-pushed
the
revisit-gevent-exception-handling
branch
from
d1f74c3 to
bb360b3
Compare
jomuel
force-pushed
the
revisit-gevent-exception-handling
branch
2 times, most recently
from
5fc2699 to
6a8e634
Compare
4 tasks
Contributor
Author
|
This PR will just revert the gevent patching, there will be follow-up prs for the remaining parts of issue #2201. |
- Due to the internal use of linking in gevent, we see no way to patch gevent to do what we want without breaking stuff - MatrixTransport client exception handler is removed too as it does nothing and these exceptions should be handled in MatrixClient
jomuel
force-pushed
the
revisit-gevent-exception-handling
branch
from
6a8e634 to
041c476
Compare
andrevmatos
approved these changes
Aug 17, 2018
Contributor
andrevmatos
left a comment
andrevmatos
left a comment
There was a problem hiding this comment.
lgtm, default gevent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.