Fix #rowtable_orders visitor helper to use first column if no pk column was found.

Author: metaskills

CHANGELOG

@@ -1,6 +1,8 @@
 
 * master *
 
+* Fix #rowtable_orders visitor helper to use first column if no pk column was found.
+
 * Flatten sp_helpconstraint when looking for constraints just in case fks are present. Issue #64.
 
 * Start to support 2011 code named "Denali".

lib/arel/visitors/sqlserver.rb

@@ -300,10 +300,10 @@ def rowtable_orders(o)
         core = o.cores.first
         if !o.orders.empty?
           o.orders
-        elsif join_in_select_statement?(o)
-          [table_from_select_statement(o).primary_key.asc]
         else
-          [table_from_select_statement(o).primary_key.asc]
+          t = table_from_select_statement(o)
+          c = t.primary_key || t.columns.first
+          [c.asc]
         end.uniq
       end
 

test/cases/specific_schema_test_sqlserver.rb

@@ -1,5 +1,6 @@
 require 'cases/sqlserver_helper'
 
+class NoPkData < ActiveRecord::Base ; self.table_name = 'no_pk_data' ; end
 class StringDefault < ActiveRecord::Base; end;
 class SqlServerEdgeSchema < ActiveRecord::Base; end;
 class SqlServerEdgeSchema < ActiveRecord::Base
@@ -13,6 +14,12 @@ def set_new_id
 
 class SpecificSchemaTestSqlserver < ActiveRecord::TestCase
 
+  should 'be able to complex count tables with no primary key' do
+    NoPkData.delete_all
+    10.times { |n| NoPkData.create! :name => "Test#{n}" }
+    assert_equal 1, NoPkData.where(:name => 'Test5').count
+  end
+  
   should 'quote table names properly even when they are views' do
     obj = SqlServerQuotedTable.create!
     assert_nothing_raised { SqlServerQuotedTable.first }

test/schema/sqlserver_specific_schema.rb

@@ -67,6 +67,10 @@
     t.column :guid, :uniqueidentifier
   end
 
+  create_table :no_pk_data, :force => true, :id => false do |t|
+    t.string :name
+  end
+  
   execute %|ALTER TABLE [sql_server_edge_schemas] ADD [guid_newid] uniqueidentifier DEFAULT NEWID();|
   execute %|ALTER TABLE [sql_server_edge_schemas] ADD [guid_newseqid] uniqueidentifier DEFAULT NEWSEQUENTIALID();|