Make sure tinyint primary key columns work. Closes #157

Author: metaskills

test/cases/specific_schema_test_sqlserver.rb

@@ -47,6 +47,17 @@ class SpecificSchemaTestSqlserver < ActiveRecord::TestCase
       @edge_class = SqlServerEdgeSchema
     end
 
+    context 'with tinyint primary key' do
+      
+      should 'work with identity inserts and finders' do
+        record = SqlServerTinyintPk.new :name => '1'
+        record.id = 1
+        record.save!
+        assert_equal record, SqlServerTinyintPk.find(1)
+      end
+      
+    end
+    
     context 'with natural primary keys' do
 
       should 'work with identity inserts' do

test/cases/sqlserver_helper.rb

@@ -40,6 +40,7 @@ class CustomersView < ActiveRecord::Base ; self.table_name = 'customers_view' ;
 class StringDefaultsView < ActiveRecord::Base ; self.table_name = 'string_defaults_view' ; end
 class StringDefaultsBigView < ActiveRecord::Base ; self.table_name = 'string_defaults_big_view' ; end
 class SqlServerNaturalPkData < ActiveRecord::Base ; self.table_name = 'natural_pk_data' ; self.primary_key = 'legacy_id' ; end
+class SqlServerTinyintPk < ActiveRecord::Base ; self.table_name = 'tinyint_pk_table' ; end
 class SqlServerNaturalPkIntData < ActiveRecord::Base ; self.table_name = 'natural_pk_int_data' ; end
 class SqlServerNaturalPkDataSchema < ActiveRecord::Base ; self.table_name = 'test.sql_server_schema_natural_id' ; end
 class SqlServerQuotedTable < ActiveRecord::Base ; self.table_name = 'quoted-table' ; end

test/schema/sqlserver_specific_schema.rb

@@ -111,6 +111,14 @@
     )
   NATURALPKINTTABLESQL
 
+  execute "IF EXISTS(SELECT * FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_NAME = 'tinyint_pk_table') DROP TABLE tinyint_pk_table"
+  execute <<-TINYITPKTABLE
+    CREATE TABLE tinyint_pk_table(
+      id tinyint NOT NULL PRIMARY KEY,
+      name nvarchar(255)
+    )
+  TINYITPKTABLE
+  
   create_table 'quoted-table', :force => true do |t|
   end
   execute "IF EXISTS (SELECT TABLE_NAME FROM INFORMATION_SCHEMA.VIEWS WHERE TABLE_NAME = 'quoted-view1') DROP VIEW [quoted-view1]"