Mimic other adapter's quoting for empty strings to integer columns.

* Fixes #164.

Author: metaskills

CHANGELOG

@@ -2,7 +2,7 @@
 * 3.2.9 *
 
 * The #remove_default_constraint uses #execute_procedure now. Fixes #223. Thanks @gicappa and @clintmiller.
-
+* Mimic other adapters quoting for empty strings passed to integer columns. Fixes #164.
 
 
 * 3.2.8 *

lib/active_record/connection_adapters/sqlserver/quoting.rb

@@ -10,7 +10,7 @@ def quote(value, column = nil)
           case value
           when String, ActiveSupport::Multibyte::Chars
             if column && column.type == :integer && value.blank?
-              nil
+              value.to_i.to_s
             elsif column && column.type == :binary
               column.class.string_to_binary(value)
             elsif value.is_utf8? || (column && column.type == :string)

test/cases/adapter_test_sqlserver.rb

@@ -377,8 +377,8 @@ def setup
             @column = Post.columns_hash['id']
           end
 
-          should "return null for empty string" do
-            assert_nil @connection.quote('', @column)
+          should "return 0 for empty string" do
+            assert_equal '0', @connection.quote('', @column)
           end
 
         end

test/cases/base_test_sqlserver.rb

@@ -1,10 +1,19 @@
 require 'cases/sqlserver_helper'
+require 'models/post'
+require 'models/auto_id'
 
 class BasicsTest < ActiveRecord::TestCase
 
   COERCED_TESTS = [:test_column_names_are_escaped]
 
   include SqlserverCoercedTest
+
+  should 'operate as other database adapters when finding primary keys, standards are postgresql adapter' do
+    assert_nil Post.where(id:'').first
+    assert_nil Post.where(id:nil).first
+    assert_raise(ActiveRecord::RecordNotFound) { Post.find('') }
+    assert_raise(ActiveRecord::RecordNotFound) { Post.find(nil) }
+  end
 
   def test_coerced_column_names_are_escaped
     assert_equal "[foo]]bar]", ActiveRecord::Base.connection.quote_column_name("foo]bar")