The #remove_default_constraint uses #execute_procedure now.

* Fixes #223.
* Thanks @gicappa and @clintmiller.

Author: metaskills

CHANGELOG

@@ -1,7 +1,13 @@
 
+* 3.2.9 *
+
+* The #remove_default_constraint uses #execute_procedure now. Fixes #223. Thanks @gicappa and @clintmiller.
+
+
+
 * 3.2.8 *
 
-Include VERSION in gemspec's files.
+* Include VERSION in gemspec's files.
 
 
 * 3.2.7 *

lib/active_record/connection_adapters/sqlserver/schema_statements.rb

@@ -250,7 +250,7 @@ def remove_check_constraints(table_name, column_name)
 
         def remove_default_constraint(table_name, column_name)
           # If their are foreign keys in this table, we could still get back a 2D array, so flatten just in case.
-          select_all("EXEC sp_helpconstraint '#{quote_string(table_name)}','nomsg'").flatten.select do |row|
+          execute_procedure(:sp_helpconstraint, table_name, 'nomsg').flatten.select do |row|
             row['constraint_type'] == "DEFAULT on column #{column_name}"
           end.each do |row|
             do_execute "ALTER TABLE #{quote_table_name(table_name)} DROP CONSTRAINT #{row['constraint_name']}"

test/cases/migration_test_sqlserver.rb

@@ -48,7 +48,7 @@ def setup
 
     should 'not drop the default contraint if just renaming' do
       find_default = lambda do 
-        @connection.select_all("EXEC sp_helpconstraint 'defaults','nomsg'").select do |row|     
+        @connection.execute_procedure(:sp_helpconstraint, 'defaults', 'nomsg').select do |row|     
           row['constraint_type'] == "DEFAULT on column decimal_number"
         end.last
       end