Fix to the #remove_default_constraint method #223
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses an issue with the remove_default_constraint method in the SchemaStatements module. When a database table has both default constraints and foreign key constraints, the return of both constraint tables (by the sp_helpconstraint procedure) break the filtering by constraint name that this method expects to be able to perform successfully. This will break migrations that remove columns with default constraints.
By changing the execution of the stored procedure from select_all to execute_procedure the results are returned in a way that the filtering works as expected.
Hat-tip to gicappa/activerecord-sqlserver-adapter@88e8c87