Skip to content

Commit d8d0a0c

Browse files
committed
Few test coercions prepare for Rails 5.
1 parent d66ed89 commit d8d0a0c

File tree

1 file changed

+5
-34
lines changed

1 file changed

+5
-34
lines changed

test/cases/coerced_tests.rb

Lines changed: 5 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,10 @@ def test_column_names_are_escaped_coerced
7373
# Just like PostgreSQLAdapter does.
7474
coerce_tests! :test_respect_internal_encoding
7575

76+
# Caused in Rails v4.2.5 by adding `firm_id` column in this http://git.io/vBfMs
77+
# commit. Trust Rails has this covered.
78+
coerce_tests! :test_find_keeps_multiple_group_values
79+
7680
end
7781

7882

@@ -406,41 +410,8 @@ class BigNumber < ActiveRecord::Base
406410
end
407411
class MigrationTest < ActiveRecord::TestCase
408412

413+
# PENDING: [Rails5.x] Remove coerced tests and use simple symbol types.
409414
coerce_tests! :test_add_table_with_decimals
410-
def test_add_table_with_decimals_coerced
411-
Person.connection.drop_table :big_numbers rescue nil
412-
assert !BigNumber.table_exists?
413-
GiveMeBigNumbers.up
414-
assert BigNumber.create(
415-
:bank_balance => 1586.43,
416-
:big_bank_balance => BigDecimal("1000234000567.95"),
417-
:world_population => 6000000000,
418-
:my_house_population => 3,
419-
:value_of_e => BigDecimal("2.7182818284590452353602875")
420-
)
421-
b = BigNumber.first
422-
assert_not_nil b
423-
assert_not_nil b.bank_balance
424-
assert_not_nil b.big_bank_balance
425-
assert_not_nil b.world_population
426-
assert_not_nil b.my_house_population
427-
assert_not_nil b.value_of_e
428-
# SQLServer: We rock and cast during assignment.
429-
assert_kind_of BigDecimal, b.world_population
430-
assert_equal BigDecimal('6000000000'), b.world_population
431-
# TODO: Our trust the DB policy breaks this expectation. Review SQLServer::Type::Castable module.
432-
skip
433-
assert_kind_of Fixnum, b.my_house_population
434-
assert_equal 3, b.my_house_population
435-
assert_kind_of BigDecimal, b.bank_balance
436-
assert_equal BigDecimal("1586.43"), b.bank_balance
437-
assert_kind_of BigDecimal, b.big_bank_balance
438-
assert_equal BigDecimal("1000234000567.95"), b.big_bank_balance
439-
assert_kind_of BigDecimal, b.value_of_e
440-
assert_equal BigDecimal("2.7182818284590452353602875"), b.value_of_e
441-
GiveMeBigNumbers.down
442-
assert_raise(ActiveRecord::StatementInvalid) { BigNumber.first }
443-
end
444415

445416
end
446417

0 commit comments

Comments
 (0)