invalid ORDER BY clause generated if used with a function call with commas in it

[sys-64738]

As noted in #155 , the adapter fails to create a correct ORDER BY clause if the order criteria is an expression that contains commas. 53a248a includes a code comment # Allow functions with comma(s) to pass thru. which suggests that this is working, but it is not. The code of the order method initially splits the input string by commas, then adds ASC to each array element (i.e. ORDER BY FOO(1,2,3) becomes ORDER BY FOO(1 ASC, 2 ASC, 3) ASC.

To fix this, the code would have to match opening and closing brackets in order to catch only commas outside the outer brackets of the expression.

[metaskills]

Rails nor the adapter can not be a library of regular expressions. In this case were you are passing down a complex order, you should give it an Arel.sql('...') literal string. The visitor should let this go thru just fine.

[sys-64738]

My point is mostly that the code (and inline comments) of the order method looks like it had the intention to solve the problem - using regular expressions - but it doesn't work as intended.

I already had the suggested workaround from #155 in place with Rails 3.0. With 3.2 it was causing an exception because Arel::Nodes::Ordering's constructor had changed. So I looked at the code which suggested that strings would be working now with 3.2 and now I'm here. If the method accepts SQL strings, you would expect it handles them properly?

[metaskills]

This is not an issue in the 4.2 adapter since we now use OFFSET/FETCH.

[perryventas]

I've got exactly the same problem - is there a way to bypass this bug?

[metaskills]

Use an Arel.sql('...') literal string?