Tables with same name in different database schema's

[ianic]

When two tables with same name exists in different database schema's adapter returns columns of both. That results in various problems.
For example when I have two tables:
dbo.table1 - with 2 columns
project1.table1 - with 3 columns
Adapter returns 5 columns!

Problem is in SQLServerAdapter.columns method which incorrectly handles table schema's.

I have patch (for 2-3-stable branch) but where should I put it?
Thanks

[metaskills]

I thought we handled this in the schema info somehow. Can you post a gist of your patch and put a link to it here? Did you also add a regression test?

[ianic]

Here is the patch: http://files.minus5.hr/schema_patch.diff

I made one new test file: test/cases/schema_test_sqlserver.rb
Had to add database schema (test) and few tables in test/schema/sqlserver_specific_schema.rb

But main change is added line in column_definitions method to use database schema when querying INFORMATION_SCHEMA.COLUMNS:
WHERE columns.TABLE_NAME = '#{table_name}'
and columns.TABLE_SCHEMA = #{table_schema.nil? ? "schema_name() " : "'#{table_schema}' "}

[metaskills]

Hefty! Will look this over later. Thanks!

[metaskills]

I get an error with that patch. Can you make a gist of it?

[ianic]

Sorry, here it is: https://gist.github.com/881602

[metaskills]

This is awesome work! Honestly, one of the best patches to the adapter ever. Well thought out and passing the tests. One problem tho. I only have time to apply this to the master branch for rails 3.0. I then have to go thru all the work to rebase the 3.1 branch and make it work too as it has to parameterize the args too. I then have to run tests for 2005 as well as Azure too and that kills all my time.

Was your only interest in the 2-3-stable branch?

[ianic]

That's ok with me.
We are just in process of moving our production from Rails 2.3 to 3.0.
Glad to see that this is now part of main branch.
Thanks.