Pass tds_version to TinyTds::Client.new #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metaskills
added a commit
that referenced
this pull request
Jul 7, 2013
Pass tds_version to TinyTds::Client.new
Member
|
Thanks, will have v3.2.13 out with this change very shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some troubles with encoding. SQL Server 2005, encoding cp1251. I tried to use
tsql, it worked. Then I checked version, and found that it worked with tds version 4.2 by default. So I tried to initialize TinyTds::Client with tds_version 42, and it worked fine too. Then, when I puttds_version: '42'intoconfig/database.yml, it did not work, and I found that this option was not passed to TinyTds::Client.new. This small patch is intended to fix this issue.