Skip to content

Fixes issue 237: "No such column" when renaming some columns in the migrations #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2013
Merged

Fixes issue 237: "No such column" when renaming some columns in the migrations #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfebf08
clear_table_cache before each rename_column
michelgrootjans Jan 14, 2013
166c64f
ignore rubymine-generated files
michelgrootjans Jan 14, 2013
ddc11ab
bugfix
michelgrootjans Jan 14, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ Gemfile.lock
test/profile/output/*
.rvmrc
.rbenv-version
.idea
1 change: 1 addition & 0 deletions lib/active_record/connection_adapters/sqlserver/schema_statements.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ def change_column_default(table_name, column_name, default)
end

def rename_column(table_name, column_name, new_column_name)
schema_cache.clear_table_cache!(table_name)
detect_column_for! table_name, column_name
do_execute "EXEC sp_rename '#{table_name}.#{column_name}', '#{new_column_name}', 'COLUMN'"
end
Expand Down