Rails 4 compatible UUID Support #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Putting this here is kind of messy. To keep the adapter clean, I adopted a director structure that followed the file/module naming components of ActiveRecord's abstract adapter. This allows others to each follow along and contribute.
Please move this to active_record/connection_adapters/sqlserver/schema_creation.rb to match the abstract adapter.
Member
|
Thanks for the PR! I have made a few comments on structure. These may seem persnickety, but keeping the project clean and following file/module naming convention helps others approach the adapter and contribute. |
Contributor
Author
|
Restructured accordingly, take a look when you can |
Member
|
Thanks @agios!!! cc/@annaswims |
Contributor
|
I'm so glad you did this. I'll review within the next few days. |
annaswims
added a commit
that referenced
this pull request
May 15, 2014
Rails 4 compatible UUID Support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.