Rails 4.1 Support by wbond · Pull Request #331 · rails-sqlserver/activerecord-sqlserver-adapter

The tests now run with rails 4.1.0

Anna Carey

authored and

wbond

committed

Fixed bind type casting to re-set the casted value back to the bind, fixed bind parameter tests to work with SQL server

wbond

committed

Added the :authors fixture to AdapterTest to fix a failure in test_select_methods_passing_a_association_relation

wbond

committed

Type casting is now happening, so the test regex needs to be updated

wbond

committed

The test test_to_sql_on_eager_join was seeing slightly different result in that the SQL was embedded in a call to sp_executesql, which seems ok to me

wbond

committed

Rails 4.1 seems to use strings for database config keys nows

wbond

committed

Fix how we are checking bind tests, can't use coerce since the test methods are defined in an if block

wbond

committed

Fixed tests in rails/activerecord/test/cases/connection_adapters/connection_handler_test.rb by setting the RAILS_ENV to 'default_env'

wbond

committed

Unescape quotes from default values

wbond

committed

Added support for create_table :as, which fixes tests MigrationTest#test_create_table_with_query and MigrationTest#test_create_table_with_query_from_relation

wbond

committed

Clear the schema cache for a table after creating it to prevent a cached negative response - fixes test ActiveRecord::Migration::ChangeSchemaTest#test_change_column_null

wbond

committed

PersistencesTest was renamed to PersistenceTest in rails 4.1, so we have to do it in our codebase also

wbond

committed

Use Arel::Nodes::BindParam instead of Arel.sql for substitute_at so that ActiveRecord::Relation merging works properly - tests RelationMergingTest#test_merging_reorders_bind_params and RelationMerg…

wbond

committed

Coerced test for ActiveRecord::PredicateBuilderTest#test_registering_new_handlers since the regex doesn't work for T-SQL

wbond

committed

Fixed test NamedScopingTest#test_scopes_honor_current_scopes_from_when_defined by adding a second column to the ORDER BY condition of the :ranked_by_comments scope of the Post model

wbond

committed

Added savepoint name param to create_savepoint, release_savepoint and rollback_to_savepoint

wbond

committed

Updated UUID enhancements to work with rails 4.1 API

wbond

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rails 4.1 Support#331

Rails 4.1 Support#331
annaswims merged 17 commits intorails-sqlserver:masterfrom
veracross:rails-4-1-0

Commits on May 16, 2014

The tests now run with rails 4.1.0

Fixed bind type casting to re-set the casted value back to the bind, fixed bind parameter tests to work with SQL server

Added the :authors fixture to AdapterTest to fix a failure in test_select_methods_passing_a_association_relation

Type casting is now happening, so the test regex needs to be updated

The test test_to_sql_on_eager_join was seeing slightly different result in that the SQL was embedded in a call to sp_executesql, which seems ok to me

Rails 4.1 seems to use strings for database config keys nows

Fix how we are checking bind tests, can't use coerce since the test methods are defined in an if block

Fixed tests in rails/activerecord/test/cases/connection_adapters/connection_handler_test.rb by setting the RAILS_ENV to 'default_env'

Unescape quotes from default values

Added support for create_table :as, which fixes tests MigrationTest#test_create_table_with_query and MigrationTest#test_create_table_with_query_from_relation

Clear the schema cache for a table after creating it to prevent a cached negative response - fixes test ActiveRecord::Migration::ChangeSchemaTest#test_change_column_null

PersistencesTest was renamed to PersistenceTest in rails 4.1, so we have to do it in our codebase also

Use Arel::Nodes::BindParam instead of Arel.sql for substitute_at so that ActiveRecord::Relation merging works properly - tests RelationMergingTest#test_merging_reorders_bind_params and RelationMerg…

Coerced test for ActiveRecord::PredicateBuilderTest#test_registering_new_handlers since the regex doesn't work for T-SQL

Fixed test NamedScopingTest#test_scopes_honor_current_scopes_from_when_defined by adding a second column to the ORDER BY condition of the :ranked_by_comments scope of the Post model

Added savepoint name param to create_savepoint, release_savepoint and rollback_to_savepoint

Updated UUID enhancements to work with rails 4.1 API

Rails 4.1 Support#331annaswims merged 17 commits intorails-sqlserver:masterrails-sqlserver/activerecord-sqlserver-adapter:masterfrom veracross:rails-4-1-0Copy head branch name to clipboard

Commits

Commits on May 16, 2014

Rails 4.1 Support#331
annaswims merged 17 commits intorails-sqlserver:masterfrom
veracross:rails-4-1-0