Skip to content

[Rails 5] Fix some times coming back nil after save. #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2017
Merged

[Rails 5] Fix some times coming back nil after save. #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/active_record/connection_adapters/sqlserver/type/datetime.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def serialize(value)
return super unless value.acts_like?(:time)
datetime = super.to_s(:_sqlserver_datetime).tap do |v|
fraction = quote_fractional(value)
v << ".#{fraction}" unless fraction.to_i.zero?
v << ".#{fraction}"
end
Data.new datetime, self
end
Expand Down
2 changes: 1 addition & 1 deletion lib/active_record/connection_adapters/sqlserver/type/time.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ def serialize(value)
return super unless value.acts_like?(:time)
time = value.to_s(:_sqlserver_time).tap do |v|
fraction = quote_fractional(value)
v << ".#{fraction}" unless fraction.to_i.zero?
v << ".#{fraction}"
end
Data.new time, self
end
Expand Down
2 changes: 1 addition & 1 deletion test/cases/schema_dumper_test_sqlserver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class SchemaDumperTestSQLServer < ActiveRecord::TestCase
assert_line :datetime2_3, type: 'datetime2', limit: nil, precision: 3, scale: nil, default: nil
assert_line :datetime2_1, type: 'datetime2', limit: nil, precision: 1, scale: nil, default: nil
end
assert_line :smalldatetime, type: 'smalldatetime',limit: nil, precision: nil, scale: nil, default: "01-01-1901 15:45:00"
assert_line :smalldatetime, type: 'smalldatetime',limit: nil, precision: nil, scale: nil, default: "01-01-1901 15:45:00.0"
if connection_dblib_73?
assert_line :time_7, type: 'time', limit: nil, precision: 7, scale: nil, default: "04:20:00.2883215"
assert_line :time_2, type: 'time', limit: nil, precision: 2, scale: nil, default: nil
Expand Down