[Rails5] Pass more attribute tests for date/time/zones. #542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another chapter in an epic series of getting our custom date time types passing all tests. I feel like we are in a constant battle that has gone downhill since we have to have specific quoting for each datetime type/precision that typically follows
%m-%d-%Yformat. This has been complicated by the fact that as part of forgetting assignment we could not rely on ActiveModel/Record to pare these strings for us which does not support a) our formats and b) time zones. I am willing to admit that all this work could somehow be easier but I can not see it. Other PRs include:_type_cast&_quote. #534Now that we only have a few dozen tests failing. I might try this freedom patch again to see if things really break dirty support and/or helps reduce the complexity.
cc @sgrif