Skip to content

Conversation

@metaskills
Copy link
Member

Another chapter in an epic series of getting our custom date time types passing all tests. I feel like we are in a constant battle that has gone downhill since we have to have specific quoting for each datetime type/precision that typically follows %m-%d-%Y format. This has been complicated by the fact that as part of forgetting assignment we could not rely on ActiveModel/Record to pare these strings for us which does not support a) our formats and b) time zones. I am willing to admit that all this work could somehow be easier but I can not see it. Other PRs include:

Now that we only have a few dozen tests failing. I might try this freedom patch again to see if things really break dirty support and/or helps reduce the complexity.

cc @sgrif

@metaskills
Copy link
Member Author

OK, is what it is... #504 is no help in reducing complexity. I think it is all normal for us or my lack to find the simple path.

@metaskills metaskills merged commit 9faa340 into master Jan 7, 2017
@metaskills metaskills deleted the rails5-moredatetime branch January 15, 2017 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants