Don't disable referential integrity for the same table twice #638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following caught my eye when running
connection.disable_referential_integrity { ... }in a Rails console (using v4.2.18 of the adapter):Apparently duplicates are not eliminated when determining the set of tables with foreign key constraints.
In our case the adapter emitted 2 * 256
ALTER TABLE ... (NO)CHECK CONSTRAINT ALLstatements instead of the sufficient 2 * 167.It would be lovely to see this fix in the 4.2 line as well.