Skip to content

Fix Time value precision calculation #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Fix Time value precision calculation #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/active_record/connection_adapters/sqlserver/type/time_value_fractional.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,16 @@ module TimeValueFractional
def apply_seconds_precision(value)
return value if !value.respond_to?(fractional_property) || value.send(fractional_property).zero?
value.change fractional_property => seconds_precision(value)

millis = seconds_precision(value).to_i
value = value.change fractional_property => millis % fractional_operator
value + millis / fractional_operator
end

def seconds_precision(value)
return 0 if fractional_scale == 0
seconds = value.send(fractional_property).to_d / fractional_operator.to_d
seconds = ((seconds * (1 / fractional_precision)).round / (1 / fractional_precision)).truncate(fractional_scale)
seconds = ((seconds / fractional_precision).round * fractional_precision).round(fractional_scale)
(seconds * fractional_operator).round(0).to_i
end

Expand All @@ -39,7 +43,7 @@ def fractional_operator
end

def fractional_precision
BigDecimal('0.00333')
BigDecimal('0.003333')
end

def fractional_scale
Expand Down
4 changes: 2 additions & 2 deletions test/cases/coerced_tests.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,14 +223,14 @@ class QuoteARBaseTest < ActiveRecord::TestCase
coerce_tests! :test_quote_ar_object
def test_quote_ar_object_coerced
value = DatetimePrimaryKey.new(id: @time)
assert_equal "'02-14-2017 12:34:56.789'", @connection.quote(value)
assert_equal "'02-14-2017 12:34:56.79'", @connection.quote(value)
end

# Use our date format.
coerce_tests! :test_type_cast_ar_object
def test_type_cast_ar_object_coerced
value = DatetimePrimaryKey.new(id: @time)
assert_equal "02-14-2017 12:34:56.789", @connection.type_cast(value)
assert_equal "02-14-2017 12:34:56.79", @connection.type_cast(value)
end

end
Expand Down