Rails 6: Subqueries cannot include ordering unless TOP/LIMIT also specified #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanharan
force-pushed
the
in-clause-no-ordering
branch
from
a3f4e6b to
2e57fe4
Compare
aidanharan
force-pushed
the
in-clause-no-ordering
branch
from
2e57fe4 to
3d3faf8
Compare
aidanharan
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MSSQL subqueries cannot have ordering unless they include
TOPorOFFSET, otherwise aThe ORDER BY clause is invalid in views, inline functions, derived tables, subqueries, and common table expressions, unless TOP, OFFSET or FOR XML is also specified.error is returned.Note that ordering in subqueries is valid if it includes
FOR XMLbut this use-case is not supported in the adapter.Before
https://travis-ci.org/github/rails-sqlserver/activerecord-sqlserver-adapter/jobs/670183329?utm_medium=notification&utm_source=github_status
After
https://travis-ci.org/github/rails-sqlserver/activerecord-sqlserver-adapter/jobs/671990453?utm_medium=notification&utm_source=github_status