Rails 6.1: Fix removal of invalid ordering from select statements #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanharan
changed the title
aidanharan
force-pushed
the
remove-invalid-ordering-from-in-clause
branch
from
4685e6a to
be7b922
Compare
aidanharan
force-pushed
the
remove-invalid-ordering-from-in-clause
branch
from
be7b922 to
e08fe43
Compare
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
…er#890) Co-authored-by: Aidan Haran <aharan@fusioneer.com> Co-authored-by: Wanderson Policarpo <wpolicarpo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
The ORDER BY clause is invalid in views, inline functions, derived tables, subqueries, and common table expressions, unless TOP, OFFSET or FOR XML is also specifiedtest errors.The
Arel::Visitors::ToSql#collect_in_clausemethod was removed in rails/rails#39057 so the fix for the issue (#758) needs to be moved.Before
https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/runs/2382157889
7130 runs, 20222 assertions, 28 failures, 33 errors, 36 skips
After
https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/890/checks?check_run_id=2384346870
7133 runs, 20264 assertions, 28 failures, 19 errors, 36 skips