Skip to content

Rails 6: Fix fully qualified identifier tests #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2020
Merged

Rails 6: Fix fully qualified identifier tests #771

merged 1 commit into from
Apr 15, 2020

Conversation

@aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Apr 15, 2020 •
edited
Loading

This PR fixes the following tests:

  • FullyQualifiedIdentifierTestSQLServer::remote server#test_0004_should not use fully qualified table name in order clause
  • FullyQualifiedIdentifierTestSQLServer::remote server#test_0005_should use fully qualified table name in insert statement

Before
https://travis-ci.org/github/rails-sqlserver/activerecord-sqlserver-adapter/jobs/674956935

6728 runs, 18681 assertions, 39 failures, 12 errors, 25 skips

After
https://travis-ci.org/github/rails-sqlserver/activerecord-sqlserver-adapter/jobs/675213049

6728 runs, 18695 assertions, 38 failures, 10 errors, 25 skips

@aidanharan aidanharan changed the title Rails 6: Fully qualified identifier tests Rails 6: Fix fully qualified identifier tests Apr 15, 2020
@aidanharan aidanharan marked this pull request as ready for review April 15, 2020 09:32
@wpolicarpo wpolicarpo merged commit 16c3949 into rails-sqlserver:6-0-dev Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aidanharan @wpolicarpo