Skip to content

Rails 6: Fix fully qualified identifier tests #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Rails 6: Fix fully qualified identifier tests #771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/cases/fully_qualified_identifier_test_sqlserver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ class FullyQualifiedIdentifierTestSQLServer < ActiveRecord::TestCase

it 'should not use fully qualified table name in order clause' do
table = Arel::Table.new(:table)
expected_sql = "SELECT * FROM [my.server].[db].[schema].[table] ORDER BY [table].[name]"
expected_sql = "SELECT * FROM [my.server].[db].[schema].[table] ORDER BY [table].[name]"
assert_equal expected_sql, table.project(Arel.star).order(table[:name]).to_sql
end

it 'should use fully qualified table name in insert statement' do
manager = Arel::InsertManager.new
manager.into Arel::Table.new(:table)
manager.values = manager.create_values [Arel.sql('*')], %w{ a }
manager.values = manager.create_values [Arel.sql('*')]
expected_sql = "INSERT INTO [my.server].[db].[schema].[table] VALUES (*)"
quietly { assert_equal expected_sql, manager.to_sql }
end
Expand Down