Rails 6: Log subscriber workaround #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanharan
force-pushed
the
log-subscriber-fix
branch
from
b3fd194 to
aee5f7a
Compare
aidanharan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround to fix the failing
LogSubscriberTest#test_vebose_query_logstest on the CI by calling the original test from the coerced test.The issue seems to be caused by the adapter installing Rails as a gem and the
ActiveSupport::BacktraceCleaner, which cleans up backtraces and is used byActiveRecord::LogSubscriber. It seems to be silencing calls from installed gems.References:
rails/rails#33455