Handle default boolean column values when deduplicating #875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the "bit" type column error
NoMethodError: undefined method '-@' for true:TrueClass.Issue was that the default value for a column in the SQL Server adapter can be true/false. However, the true/false classes do not implement the '-@' method to return a frozen version of the value. However, since true/false are already frozen there is no need to call the
-@method anyway.Tests Before
https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/runs/2342106156
7133 runs, 8923 assertions, 36 failures, 3373 errors, 33 skips
Tests After
https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/875/checks?check_run_id=2342446944
7133 runs, 14121 assertions, 38 failures, 1590 errors, 37 skips