Handle any default column class when deduplicating #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanharan
force-pushed
the
deduplicate-date-value
branch
from
1dfb90f to
686a21d
Compare
aidanharan
force-pushed
the
deduplicate-date-value
branch
from
686a21d to
a67c311
Compare
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
Co-authored-by: Aidan Haran <aharan@fusioneer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in #875 the column deduplication method was updated to handle default boolean values. The change did not handle other non-string classes such as Time/Date/Integer/etc. This is the cause of the
NoMethodError: undefined method '-@'errors in the main CI build:https://pipelines.actions.githubusercontent.com/OGQvFf2eDbGUprKdJ5qsq3TsAFLfKWDWAJCyTHn8ess0fbvp0X/_apis/pipelines/1/runs/67/signedlogcontent/6?urlExpires=2021-04-15T12%3A48%3A19.5876504Z&urlSigningMethod=HMACV1&urlSignature=BboOo2lvNJlxvLAzbOHeep1jlPH%2FtSuW75%2BiBiJvq1s%3D
Updated the
ActiveRecord::ConnectionAdapters::SQLServerColumn#deduplicatedmethod to create a frozen copy of any object that is not a String.Before
https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/runs/2354091308
7133 runs, 18455 assertions, 26 failures, 145 errors, 37 skips
After
https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/880/checks?check_run_id=2354573868
7133 runs, 20119 assertions, 25 failures, 80 errors, 37 skips