Skip to content

Rails 6.1: coerce tests when we produce more or less queries #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 21, 2021
Merged

Rails 6.1: coerce tests when we produce more or less queries #901

merged 4 commits into from
Apr 21, 2021

Conversation

@mgrunberg
Copy link
Contributor

@mgrunberg mgrunberg commented Apr 21, 2021

PR fixes the following failures:

BasePreventWritesTest::BasePreventWritesLegacyTest#test_0006_an empty transaction does not raise if preventing writes [/usr/local/bundle/bundler/gems/rails-8b63ea762239/activerecord/test/cases/base_prevent_writes_test.rb:164]:
1 instead of 2 queries were executed.

BasePreventWritesTest#test_0006_an empty transaction does not raise if preventing writes [/usr/local/bundle/bundler/gems/rails-8b63ea762239/activerecord/test/cases/base_prevent_writes_test.rb:61]:
1 instead of 2 queries were executed.

ActiveRecord::AdapterPreventWritesLegacyTest#test_errors_when_an_insert_query_is_called_while_preventing_writes [/usr/local/bundle/bundler/gems/rails-8b63ea762239/activerecord/test/cases/adapter_prevent_writes_test.rb:181]:
6 instead of 0 queries were executed.

wpolicarpo
wpolicarpo reviewed Apr 21, 2021
View reviewed changes
aidanharan
aidanharan reviewed Apr 21, 2021
View reviewed changes
@mgrunberg mgrunberg force-pushed the issues/yellowspot/rails-6-1/coerce-test-when-we-produce-more-or-less-queries branch from 4e46ffc to a0d18d9 Compare April 21, 2021 13:08
@wpolicarpo wpolicarpo merged commit 887683e into rails-sqlserver:main Apr 21, 2021
@aidanharan aidanharan mentioned this pull request Apr 22, 2021
Merged
@mgrunberg mgrunberg deleted the issues/yellowspot/rails-6-1/coerce-test-when-we-produce-more-or-less-queries branch January 3, 2022 17:32
lavika pushed a commit to lavika/activerecord-sqlserver-adapter that referenced this pull request Sep 26, 2023
@mgrunberg
Rails 6.1: coerce tests when we produce more or less queries (rails-s…
276f37b 
…qlserver#901)

* coerce test because we produce some read queries

* coerce test because we open less transactions

* change coerced test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpolicarpo wpolicarpo wpolicarpo left review comments

@aidanharan aidanharan aidanharan left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgrunberg @wpolicarpo @aidanharan