Rails 6.1: Fixed the namespace of the BasePreventWritesLegacyTest class #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanharan
changed the title
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
…qlserver#911) Co-authored-by: Aidan Haran <aharan@fusioneer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the
BasePreventWritesTest::BasePreventWritesLegacyTest#test_0006_an empty transaction does not raise if preventing writestest is still failing (see https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/runs/2409001850) even though it was being coerced in #901The issue is that the coerce is for the
BasePreventWritesLegacyTestclass not theBasePreventWritesTest::BasePreventWritesLegacyTestclass (https://github.com/rails/rails/blob/738ca3595fb88580a84072b31ce8a999af4762d6/activerecord/test/cases/base_prevent_writes_test.rb#L98).This PR just moves the class into the correct namespace.