Skip to content

Rails 6.1: coerce test to match binding syntax #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2021
Merged

Rails 6.1: coerce test to match binding syntax #908

merged 1 commit into from
Apr 22, 2021

Conversation

@mgrunberg
Copy link
Contributor

@mgrunberg mgrunberg commented Apr 21, 2021 •
edited
Loading

Split #902 into two separate PR.

PR fixes:

RelationMergingTest#test_merge_doesnt_duplicate_same_clauses [/usr/local/bundle/bundler/gems/rails-8b63ea762239/activerecord/test/cases/relation/merging_test.rb:202]:
Query pattern(s) /WHERE \[authors\]\.\[id\] NOT IN \((\?|\W?\w?\d), \g<1>\)\z/ not found.

@wpolicarpo wpolicarpo merged commit 5514dc0 into rails-sqlserver:main Apr 22, 2021
@mgrunberg mgrunberg deleted the issues/yellowspot/rails-6-1/coerce-test-to-match-binding-syntax branch January 3, 2022 17:31
lavika pushed a commit to lavika/activerecord-sqlserver-adapter that referenced this pull request Sep 26, 2023
@mgrunberg
coerse test to change binding syntax to @n (rails-sqlserver#908)
4d4fa8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgrunberg @wpolicarpo