Skip to content

Rails 6.1: coerce test to match binding syntax #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Rails 6.1: coerce test to match binding syntax #908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions test/cases/coerced_tests.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1518,6 +1518,25 @@ def test_merging_with_order_with_binds_coerced
relation = Post.all.merge(Post.order([Arel.sql("title LIKE ?"), "%suffix"]))
assert_equal ["title LIKE N'%suffix'"], relation.order_values
end

# Same as original but change first regexp to match sp_executesql binding syntax
coerce_tests! :test_merge_doesnt_duplicate_same_clauses
def test_merge_doesnt_duplicate_same_clauses_coerced
david, mary, bob = authors(:david, :mary, :bob)

non_mary_and_bob = Author.where.not(id: [mary, bob])

author_id = Author.connection.quote_table_name("authors.id")
assert_sql(/WHERE #{Regexp.escape(author_id)} NOT IN \((@\d), \g<1>\)'/) do
assert_equal [david], non_mary_and_bob.merge(non_mary_and_bob)
end

only_david = Author.where("#{author_id} IN (?)", david)

assert_sql(/WHERE \(#{Regexp.escape(author_id)} IN \(1\)\)\z/) do
assert_equal [david], only_david.merge(only_david)
end
end
end

module ActiveRecord
Expand Down