Rails 6.1: Added coerced test was removed by mistake #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed instead of removed
aidanharan
force-pushed
the
revert-removal-of-coerced-test
branch
from
810de1c to
7db2690
Compare
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
…ed instead of removed (rails-sqlserver#909) Co-authored-by: Aidan Haran <aharan@fusioneer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI has failing test
EagerLoadingTooManyIdsTest#test_eager_loading_too_many_ids.This test was originally called
test_eager_loading_too_may_ids, which contains a typo. The typo was fixed in rails/rails@60ff119Instead of removing
test_eager_loading_too_may_idsin https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/887/files#diff-3f00d8ac91cdd36f48a1f18eb12bf3dc8d3cb7e48f7d21fc891ea63dfb6fd9ecL1460 the test should have been renamed.This PR just adds back in the coerce and renames the test.