Primary key violation should result in RecordNotUnique error #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
…qlserver#940) * Primary key violation should result in ActiveRecord::RecordNotUnique error * Updated changelog Co-authored-by: Aidan Haran <aharan@fusioneer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a record that violates a primary key constraint should throw an
ActiveRecord::RecordNotUniqueerror rather than the genericActiveRecord::StatementInvaliderror.The issue was caused by how the adapter was translating MSSQL errors into ActiveRecord errors. We were handling unique key violations but not primary key violations.
Fixes #939